storage manager: bail out with an error if unsealed cid is undefined (redux) #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
fix/stgmgr-undef-unsealed
branch
from
1f461b6
to
8bbdf2e
Compare
storage: return true from Sealer.ReadPiece() on success
magik6k
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3558
The first attempt (#3615) included an extra logic change that caused some tests to fail. I'm investigating why it causes test failures.
This PR is the same but without the extra change: it just checks if the unsealed cid is undefined, and returns an error if so.